fix(pylock): respect an explicitly empty tag sequence in select() - #1349
Merged
Conversation
sbidoul
approved these changes
Jul 25, 2026
henryiii
approved these changes
Jul 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pylock.select(tags=[])currently treats the explicit empty sequence like an omitted argument and falls back to the running interpreter'ssys_tags(). That can select a host-compatible wheel even when the caller supplied no compatible tags.This changes the defaulting check to distinguish
Nonefrom an explicit empty sequence:PylockSelectError;tagsand non-empty tag sequences retain their existing behavior.Tests:
PYTHONPATH=src python3 -m pytest -q tests/test_pylock_select.py(27 passed).